Commit 8ae4c8ce authored by Christoph Hellwig's avatar Christoph Hellwig
Browse files

xfs: skip always_cow inodes in xfs_reflink_trim_around_shared 



xfs_reflink_trim_around_shared tries to find shared blocks in the
refcount btree.  Always_cow inodes don't have that tree, so don't
bother.

For the existing always_cow code this is a minor optimization.  For
the upcoming zoned code that can do COW without the rtreflink code it
avoids triggering a NULL pointer dereference.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatar"Darrick J. Wong" <djwong@kernel.org>
parent 7c879c82

fs/xfs/xfs_reflink.c

+1 −1
Original line number Diff line number Diff line
@@ -235,7 +235,7 @@ xfs_reflink_trim_around_shared( 
	int			error = 0;



	/* Holes, unwritten, and delalloc extents cannot be shared */

	if (!xfs_is_cow_inode(ip) || !xfs_bmap_is_written_extent(irec)) {

	if (!xfs_is_reflink_inode(ip) || !xfs_bmap_is_written_extent(irec)) {

		*shared = false;

		return 0;

	}