Commit 8b0c2552 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Jakub Kicinski
Browse files

bnge: return after auxiliary_device_uninit() in error path 



When auxiliary_device_add() fails, the error block calls
auxiliary_device_uninit() but does not return.  The uninit drops the
last reference and synchronously runs bnge_aux_dev_release(), which sets
bd->auxr_dev = NULL and frees the underlying object.  The subsequent
bd->auxr_dev->net = bd->netdev then dereferences NULL, which is not a
good thing to have happen when trying to clean up from an error.

Add the missing return, as the auxiliary bus documentation states is a
requirement (seems that LLM tools read documentation better than humans
do...)

Cc: Vikas Gupta <vikas.gupta@broadcom.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>
Fixes: 8ac050ec ("bng_en: Add RoCE aux device support")
Cc: stable <stable@kernel.org>
Assisted-by: gregkh_clanker_t1000
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://patch.msgid.link/2026041124-banshee-molecular-0f70@gregkh


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c058bbf0

drivers/net/ethernet/broadcom/bnge/bnge_auxr.c

+1 −0
Original line number Diff line number Diff line
@@ -194,6 +194,7 @@ void bnge_rdma_aux_device_add(struct bnge_dev *bd) 
		dev_warn(bd->dev, "Failed to add auxiliary device for ROCE\n");

		auxiliary_device_uninit(aux_dev);

		bd->flags &= ~BNGE_EN_ROCE;

		return;

	}



	bd->auxr_dev->net = bd->netdev;