Commit 8b1d858c authored Apr 18, 2025 by WangYuli Committed by Dmitry Torokhov Apr 18, 2025

Input: sparcspkr - avoid unannotated fall-through



Fix follow warnings with clang-21i (and reformat for clarity):
  drivers/input/misc/sparcspkr.c:78:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
     78 |                 case SND_TONE: break;
        |                 ^
  drivers/input/misc/sparcspkr.c:78:3: note: insert 'break;' to avoid fall-through
     78 |                 case SND_TONE: break;
        |                 ^
        |                 break;
  drivers/input/misc/sparcspkr.c:113:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
    113 |                 case SND_TONE: break;
        |                 ^
  drivers/input/misc/sparcspkr.c:113:3: note: insert 'break;' to avoid fall-through
    113 |                 case SND_TONE: break;
        |                 ^
        |                 break;
  2 warnings generated.

Signed-off-by: WangYuli <wangyuli@uniontech.com>
Link: https://lore.kernel.org/r/6730E40353C76908+20250415052439.155051-1-wangyuli@uniontech.com


Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

parent 936a25ef

drivers/input/misc/sparcspkr.c

+16 −6

Original line number	Diff line number	Diff line
		@@ -74,9 +74,14 @@ static int bbc_spkr_event(struct input_dev *dev, unsigned int type, unsigned int
		return -1;

		switch (code) {
		case SND_BELL: if (value) value = 1000;
		case SND_TONE: break;
		default: return -1;
		case SND_BELL:
		if (value)
		value = 1000;
		break;
		case SND_TONE:
		break;
		default:
		return -1;
		}

		if (value > 20 && value < 32767)
		@@ -109,9 +114,14 @@ static int grover_spkr_event(struct input_dev *dev, unsigned int type, unsigned
		return -1;

		switch (code) {
		case SND_BELL: if (value) value = 1000;
		case SND_TONE: break;
		default: return -1;
		case SND_BELL:
		if (value)
		value = 1000;
		break;
		case SND_TONE:
		break;
		default:
		return -1;
		}

		if (value > 20 && value < 32767)