Commit 8b82f656 authored by Abdun Nihaal's avatar Abdun Nihaal Committed by Jakub Kicinski
Browse files

pds_core: fix memory leak in pdsc_debugfs_add_qcq() 



The memory allocated for intr_ctrl_regset, which is passed to
debugfs_create_regset32() may not be cleaned up when the driver is
removed. Fix that by using device managed allocation for it.

Fixes: 45d76f49 ("pds_core: set up device and adminq")
Signed-off-by: default avatarAbdun Nihaal <abdun.nihaal@gmail.com>
Reviewed-by: default avatarMichal Swiatkowski <michal.swiatkowski@linux.intel.com>
Reviewed-by: default avatarShannon Nelson <shannon.nelson@amd.com>
Link: https://patch.msgid.link/20250409054450.48606-1-abdun.nihaal@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent e861041e

drivers/net/ethernet/amd/pds_core/debugfs.c

+3 −2
Original line number Diff line number Diff line
@@ -154,7 +154,8 @@ void pdsc_debugfs_add_qcq(struct pdsc *pdsc, struct pdsc_qcq *qcq) 
		debugfs_create_u32("index", 0400, intr_dentry, &intr->index);

		debugfs_create_u32("vector", 0400, intr_dentry, &intr->vector);



		intr_ctrl_regset = kzalloc(sizeof(*intr_ctrl_regset),

		intr_ctrl_regset = devm_kzalloc(pdsc->dev,

						sizeof(*intr_ctrl_regset),

						GFP_KERNEL);

		if (!intr_ctrl_regset)

			return;