Unverified Commit 8ba0e618 authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Ilpo Järvinen
Browse files

mlxbf-bootctl: Constify 'struct bin_attribute' 



The sysfs core now allows instances of 'struct bin_attribute' to be
moved into read-only memory. Make use of that to protect them against
accidental or malicious modifications.

Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Link: https://lore.kernel.org/r/20241215-sysfs-const-bin_attr-mellanox-v1-1-b6fe4f68e2ca@weissschuh.net


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent a2ec08e4

drivers/platform/mellanox/mlxbf-bootctl.c

+3 −3
Original line number Diff line number Diff line
@@ -939,7 +939,7 @@ MODULE_DEVICE_TABLE(acpi, mlxbf_bootctl_acpi_ids); 


static ssize_t mlxbf_bootctl_bootfifo_read(struct file *filp,

					   struct kobject *kobj,

					   struct bin_attribute *bin_attr,

					   const struct bin_attribute *bin_attr,

					   char *buf, loff_t pos,

					   size_t count)

{
@@ -971,9 +971,9 @@ static ssize_t mlxbf_bootctl_bootfifo_read(struct file *filp, 
	return p - buf;

}



static struct bin_attribute mlxbf_bootctl_bootfifo_sysfs_attr = {

static const struct bin_attribute mlxbf_bootctl_bootfifo_sysfs_attr = {

	.attr = { .name = "bootfifo", .mode = 0400 },

	.read = mlxbf_bootctl_bootfifo_read,

	.read_new = mlxbf_bootctl_bootfifo_read,

};



static bool mlxbf_bootctl_guid_match(const guid_t *guid,