Commit 8ba64cf2 authored Apr 04, 2025 by Boris Brezillon

drm/panthor: Update panthor_mmu::irq::mask when needed



When we clear the faulty bits in the AS mask, we also need to update
the panthor_mmu::irq::mask field otherwise our IRQ handler won't get
called again until the GPU is reset.

Changes in v2:
- Add Liviu's R-b

Changes in v3:
- Add Steve's R-b

Fixes: 647810ec ("drm/panthor: Add the MMU/VM logical block")
Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
Reviewed-by: Steven Price <steven.price@arm.com>
Link: https://lore.kernel.org/r/20250404080933.2912674-4-boris.brezillon@collabora.com


Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>

parent 7d5a3b22

drivers/gpu/drm/panthor/panthor_mmu.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -781,6 +781,7 @@ int panthor_vm_active(struct panthor_vm *vm)
		if (ptdev->mmu->as.faulty_mask & panthor_mmu_as_fault_mask(ptdev, as)) {
		gpu_write(ptdev, MMU_INT_CLEAR, panthor_mmu_as_fault_mask(ptdev, as));
		ptdev->mmu->as.faulty_mask &= ~panthor_mmu_as_fault_mask(ptdev, as);
		ptdev->mmu->irq.mask \|= panthor_mmu_as_fault_mask(ptdev, as);
		gpu_write(ptdev, MMU_INT_MASK, ~ptdev->mmu->as.faulty_mask);
		}