Commit 8bb108e4 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki Committed by Vinod Koul
Browse files

phy: freescale: Discard pm_runtime_put() return value 



Printing error messages on pm_runtime_put() returning negative values
is not particularly useful.

Returning an error code from pm_runtime_put() merely means that it has
not queued up a work item to check whether or not the device can be
suspended and there are many perfectly valid situations in which that
can happen, like after writing "on" to the devices' runtime PM "control"
attribute in sysfs for one example.

Accordingly, update mixel_lvds_phy_reset() to simply discard the return
value of pm_runtime_put().

This will facilitate a planned change of the pm_runtime_put() return
type to void in the future.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/2012926.taCxCBeP46@rafael.j.wysocki


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 8a203b05

drivers/phy/freescale/phy-fsl-imx8qm-lvds-phy.c

+2 −4
Original line number Diff line number Diff line
@@ -286,11 +286,9 @@ static int mixel_lvds_phy_reset(struct device *dev) 


	regmap_write(priv->regmap, PHY_CTRL, CTRL_RESET_VAL);



	ret = pm_runtime_put(dev);

	if (ret < 0)

		dev_err(dev, "failed to put PM runtime: %d\n", ret);

	pm_runtime_put(dev);



	return ret;

	return 0;

}



static struct phy *mixel_lvds_phy_xlate(struct device *dev,