Commit 8bd7195f authored by Yu Kuai's avatar Yu Kuai Committed by Jens Axboe
Browse files

blk-mq: remove useless checkings in blk_mq_update_nr_requests() 



1) queue_requests_store() is the only caller of
blk_mq_update_nr_requests(), where queue is already freezed, no need to
check mq_freeze_depth;
2) q->tag_set must be set for request based device, and queue_is_mq() is
already checked in blk_mq_queue_attr_visible(), no need to check
q->tag_set.

Signed-off-by: default avatarYu Kuai <yukuai3@huawei.com>
Reviewed-by: default avatarNilay Shroff <nilay@linux.ibm.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent dc1dd13d

block/blk-mq.c

+1 −8
Original line number Diff line number Diff line
@@ -4930,21 +4930,14 @@ int blk_mq_update_nr_requests(struct request_queue *q, unsigned int nr) 
{

	struct blk_mq_tag_set *set = q->tag_set;

	struct blk_mq_hw_ctx *hctx;

	int ret;

	int ret = 0;

	unsigned long i;



	if (WARN_ON_ONCE(!q->mq_freeze_depth))

		return -EINVAL;



	if (!set)

		return -EINVAL;



	if (q->nr_requests == nr)

		return 0;



	blk_mq_quiesce_queue(q);



	ret = 0;

	queue_for_each_hw_ctx(q, hctx, i) {

		if (!hctx->tags)

			continue;