Commit 8bdf8a42 authored by Heikki Krogerus's avatar Heikki Krogerus Committed by Greg Kroah-Hartman
Browse files

usb: typec: ucsi: Ack also failed Get Error commands 



It is possible that also the GET_ERROR command fails. If
that happens, the command completion still needs to be
acknowledged. Otherwise the interface will be stuck until
it's reset.

Reported-by: default avatarAmmy Yi <ammy.yi@intel.com>
Fixes: bdc62f2b ("usb: typec: ucsi: Simplified registration and I/O API")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20240531104653.1303519-1-heikki.krogerus@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f85d39dd

drivers/usb/typec/ucsi/ucsi.c

+6 −1
Original line number Diff line number Diff line
@@ -153,8 +153,13 @@ static int ucsi_exec_command(struct ucsi *ucsi, u64 cmd) 
	}



	if (cci & UCSI_CCI_ERROR) {

		if (cmd == UCSI_GET_ERROR_STATUS)

		if (cmd == UCSI_GET_ERROR_STATUS) {

			ret = ucsi_acknowledge(ucsi, false);

			if (ret)

				return ret;



			return -EIO;

		}

		return ucsi_read_error(ucsi);

	}