Unverified Commit 8c04b77f authored by Fei Shao's avatar Fei Shao Committed by Mark Brown
Browse files

spi: mt65xx: Use IRQF_ONESHOT with threaded IRQ 



This driver is migrated to use threaded IRQ since commit 5972eb05
("spi: spi-mt65xx: Use threaded interrupt for non-SPIMEM transfer"), and
we almost always want to disable the interrupt line to avoid excess
interrupts while the threaded handler is processing SPI transfer.
Use IRQF_ONESHOT for that purpose.

In practice, we see MediaTek devices show SPI transfer timeout errors
when communicating with ChromeOS EC in certain scenarios, and with
IRQF_ONESHOT, the issue goes away.

Signed-off-by: default avatarFei Shao <fshao@chromium.org>
Link: https://patch.msgid.link/20251217101131.1975131-1-fshao@chromium.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 1d24636a

drivers/spi/spi-mt65xx.c

+1 −1
Original line number Diff line number Diff line
@@ -1320,7 +1320,7 @@ static int mtk_spi_probe(struct platform_device *pdev) 


	ret = devm_request_threaded_irq(dev, irq, mtk_spi_interrupt,

					mtk_spi_interrupt_thread,

					IRQF_TRIGGER_NONE, dev_name(dev), host);

					IRQF_ONESHOT, dev_name(dev), host);

	if (ret)

		return dev_err_probe(dev, ret, "failed to register irq\n");