Commit 8c09f612 authored by Avri Altman's avatar Avri Altman Committed by Martin K. Petersen
Browse files

scsi: ufs: core: Simplify temperature exception event handling 



This commit simplifies the temperature exception event handling by removing
the ufshcd_temp_exception_event_handler() function and directly calling
ufs_hwmon_notify_event() in ufshcd_exception_event_handler().

The ufshcd_temp_exception_event_handler() function contained a placeholder
comment for platform vendors to add additional steps if required. However,
since its introduction a few years ago, no vendor has added any additional
steps. Therefore, the placeholder function is removed to streamline the
code.

Signed-off-by: default avatarAvri Altman <avri.altman@wdc.com>
Link: https://lore.kernel.org/r/20250114181205.153760-1-avri.altman@wdc.com


Reviewed-by: default avatarBean Huo <beanhuo@micron.com>
Reviewed-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent c9d27829

drivers/ufs/core/ufshcd.c

+1 −19
Original line number Diff line number Diff line
@@ -5976,24 +5976,6 @@ static void ufshcd_bkops_exception_event_handler(struct ufs_hba *hba) 
				__func__, err);

}



static void ufshcd_temp_exception_event_handler(struct ufs_hba *hba, u16 status)

{

	u32 value;



	if (ufshcd_query_attr_retry(hba, UPIU_QUERY_OPCODE_READ_ATTR,

				QUERY_ATTR_IDN_CASE_ROUGH_TEMP, 0, 0, &value))

		return;



	dev_info(hba->dev, "exception Tcase %d\n", value - 80);



	ufs_hwmon_notify_event(hba, status & MASK_EE_URGENT_TEMP);



	/*

	 * A placeholder for the platform vendors to add whatever additional

	 * steps required

	 */

}



static int __ufshcd_wb_toggle(struct ufs_hba *hba, bool set, enum flag_idn idn)

{

	u8 index;
@@ -6214,7 +6196,7 @@ static void ufshcd_exception_event_handler(struct work_struct *work) 
		ufshcd_bkops_exception_event_handler(hba);



	if (status & hba->ee_drv_mask & MASK_EE_URGENT_TEMP)

		ufshcd_temp_exception_event_handler(hba, status);

		ufs_hwmon_notify_event(hba, status & MASK_EE_URGENT_TEMP);



	ufs_debugfs_exception_event(hba, status);

}