Commit 8c0b9ed2 authored by Stanislav Fomichev's avatar Stanislav Fomichev Committed by Jakub Kicinski
Browse files

selftests: ncdevmem: don't retry EFAULT 



devmem test fails on NIPA. Most likely we get skb(s) with readable
frags (why?) but the failure manifests as an OOM. The OOM happens
because ncdevmem spams the following message:

  recvmsg ret=-1
  recvmsg: Bad address

As of today, ncdevmem can't deal with various reasons of EFAULT:
- falling back to regular recvmsg for non-devmem skbs
- increasing ctrl_data size (can't happen with ncdevmem's large buffer)

Exit (cleanly) with error when recvmsg returns EFAULT. This should at
least cause the test to cleanup its state.

Signed-off-by: default avatarStanislav Fomichev <sdf@fomichev.me>
Reviewed-by: default avatarMina Almasry <almasrymina@google.com>
Link: https://patch.msgid.link/20250904182710.1586473-1-sdf@fomichev.me


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 43a42b85

tools/testing/selftests/drivers/net/hw/ncdevmem.c

+4 −0
Original line number Diff line number Diff line
@@ -945,6 +945,10 @@ static int do_server(struct memory_buffer *mem) 
			continue;

		if (ret < 0) {

			perror("recvmsg");

			if (errno == EFAULT) {

				pr_err("received EFAULT, won't recover");

				goto err_close_client;

			}

			continue;

		}

		if (ret == 0) {