Commit 8c329057 authored by Ian Rogers's avatar Ian Rogers Committed by Namhyung Kim
Browse files

perf test: Add hwmon filename parser test 



Filename parsing maps a hwmon filename to constituent parts enum/int
parts for the hwmon config value. Add a test case for the parsing.

Signed-off-by: default avatarIan Rogers <irogers@google.com>
Cc: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: Yoshihiro Furudera <fj5100bi@fujitsu.com>
Cc: Howard Chu <howardchu95@gmail.com>
Cc: Ze Gao <zegao2021@gmail.com>
Cc: Changbin Du <changbin.du@huawei.com>
Cc: Junhao He <hejunhao3@huawei.com>
Cc: Weilin Wang <weilin.wang@intel.com>
Cc: James Clark <james.clark@linaro.org>
Cc: Oliver Upton <oliver.upton@linux.dev>
Cc: Athira Jajeev <atrajeev@linux.vnet.ibm.com>
[namhyung: add #include <linux/string.h> for strlcpy()]
Link: https://lore.kernel.org/r/20241109003759.473460-4-irogers@google.com


Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
parent 4810b761

tools/perf/tests/Build

+1 −0
Original line number Diff line number Diff line
@@ -66,6 +66,7 @@ perf-test-y += sigtrap.o 
perf-test-y += event_groups.o

perf-test-y += symbols.o

perf-test-y += util.o

perf-test-y += hwmon_pmu.o

perf-test-y += tool_pmu.o



ifeq ($(SRCARCH),$(filter $(SRCARCH),x86 arm arm64 powerpc))

tools/perf/tests/builtin-test.c

+1 −0
Original line number Diff line number Diff line
@@ -71,6 +71,7 @@ static struct test_suite *generic_tests[] = { 
	&suite__PERF_RECORD,

	&suite__pmu,

	&suite__pmu_events,

	&suite__hwmon_pmu,

	&suite__tool_pmu,

	&suite__dso_data,

	&suite__perf_evsel__roundtrip_name_test,

tools/perf/tests/hwmon_pmu.c

0 → 100644
+111 −0
Original line number Diff line number Diff line 
// SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause)

#include "debug.h"

#include "hwmon_pmu.h"

#include "tests.h"

#include <linux/compiler.h>

#include <linux/kernel.h>

#include <linux/string.h>



static int test__parse_hwmon_filename(struct test_suite *test __maybe_unused,

				      int subtest __maybe_unused)

{

	const struct hwmon_parse_test {

		const char *filename;

		enum hwmon_type type;

		int number;

		enum hwmon_item item;

		bool alarm;

		bool parse_ok;

	} tests[] = {

		{

			.filename = "cpu0_accuracy",

			.type = HWMON_TYPE_CPU,

			.number = 0,

			.item = HWMON_ITEM_ACCURACY,

			.alarm = false,

			.parse_ok = true,

		},

		{

			.filename = "temp1_input",

			.type = HWMON_TYPE_TEMP,

			.number = 1,

			.item = HWMON_ITEM_INPUT,

			.alarm = false,

			.parse_ok = true,

		},

		{

			.filename = "fan2_vid",

			.type = HWMON_TYPE_FAN,

			.number = 2,

			.item = HWMON_ITEM_VID,

			.alarm = false,

			.parse_ok = true,

		},

		{

			.filename = "power3_crit_alarm",

			.type = HWMON_TYPE_POWER,

			.number = 3,

			.item = HWMON_ITEM_CRIT,

			.alarm = true,

			.parse_ok = true,

		},

		{

			.filename = "intrusion4_average_interval_min_alarm",

			.type = HWMON_TYPE_INTRUSION,

			.number = 4,

			.item = HWMON_ITEM_AVERAGE_INTERVAL_MIN,

			.alarm = true,

			.parse_ok = true,

		},

		{

			.filename = "badtype5_baditem",

			.type = HWMON_TYPE_NONE,

			.number = 5,

			.item = HWMON_ITEM_NONE,

			.alarm = false,

			.parse_ok = false,

		},

		{

			.filename = "humidity6_baditem",

			.type = HWMON_TYPE_NONE,

			.number = 6,

			.item = HWMON_ITEM_NONE,

			.alarm = false,

			.parse_ok = false,

		},

	};



	for (size_t i = 0; i < ARRAY_SIZE(tests); i++) {

		enum hwmon_type type;

		int number;

		enum hwmon_item item;

		bool alarm;



		TEST_ASSERT_EQUAL("parse_hwmon_filename",

				parse_hwmon_filename(

					tests[i].filename,

					&type,

					&number,

					&item,

					&alarm),

				tests[i].parse_ok

			);

		if (tests[i].parse_ok) {

			TEST_ASSERT_EQUAL("parse_hwmon_filename type", type, tests[i].type);

			TEST_ASSERT_EQUAL("parse_hwmon_filename number", number, tests[i].number);

			TEST_ASSERT_EQUAL("parse_hwmon_filename item", item, tests[i].item);

			TEST_ASSERT_EQUAL("parse_hwmon_filename alarm", alarm, tests[i].alarm);

		}

	}

	return TEST_OK;

}



static struct test_case tests__hwmon_pmu[] = {

	TEST_CASE("Basic parsing test", parse_hwmon_filename),

	{	.name = NULL, }

};



struct test_suite suite__hwmon_pmu = {

	.desc = "Hwmon PMU",

	.test_cases = tests__hwmon_pmu,

};

tools/perf/tests/tests.h

+1 −0
Original line number Diff line number Diff line
@@ -92,6 +92,7 @@ DECLARE_SUITE(perf_evsel__tp_sched_test); 
DECLARE_SUITE(syscall_openat_tp_fields);

DECLARE_SUITE(pmu);

DECLARE_SUITE(pmu_events);

DECLARE_SUITE(hwmon_pmu);

DECLARE_SUITE(tool_pmu);

DECLARE_SUITE(attr);

DECLARE_SUITE(dso_data);