Commit 8c619eb2 authored by Oleksij Rempel's avatar Oleksij Rempel Committed by Paolo Abeni
Browse files

net: phy: micrel: remove KSZ9477 EEE quirks now handled by phylink 



The KSZ9477 PHY driver contained workarounds for broken EEE capability
advertisements by manually masking supported EEE modes and forcibly
disabling EEE if MICREL_NO_EEE was set.

With proper MAC-side EEE handling implemented via phylink, these quirks
are no longer necessary. Remove MICREL_NO_EEE handling and the use of
ksz9477_get_features().

This simplifies the PHY driver and avoids duplicated EEE management logic.

Signed-off-by: default avatarOleksij Rempel <o.rempel@pengutronix.de>
Cc: stable@vger.kernel.org # v6.14+
Link: https://patch.msgid.link/20250504081434.424489-3-o.rempel@pengutronix.de


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 76ca05e0

drivers/net/phy/micrel.c

+0 −7
Original line number Diff line number Diff line
@@ -2027,12 +2027,6 @@ static int ksz9477_config_init(struct phy_device *phydev) 
			return err;

	}



	/* According to KSZ9477 Errata DS80000754C (Module 4) all EEE modes

	 * in this switch shall be regarded as broken.

	 */

	if (phydev->dev_flags & MICREL_NO_EEE)

		phy_disable_eee(phydev);



	return kszphy_config_init(phydev);

}
@@ -5705,7 +5699,6 @@ static struct phy_driver ksphy_driver[] = { 
	.handle_interrupt = kszphy_handle_interrupt,

	.suspend	= genphy_suspend,

	.resume		= ksz9477_resume,

	.get_features	= ksz9477_get_features,

} };



module_phy_driver(ksphy_driver);

include/linux/micrel_phy.h

+0 −1
Original line number Diff line number Diff line
@@ -44,7 +44,6 @@ 
#define MICREL_PHY_50MHZ_CLK	BIT(0)

#define MICREL_PHY_FXEN		BIT(1)

#define MICREL_KSZ8_P1_ERRATA	BIT(2)

#define MICREL_NO_EEE		BIT(3)



#define MICREL_KSZ9021_EXTREG_CTRL	0xB

#define MICREL_KSZ9021_EXTREG_DATA_WRITE	0xC