Commit 8c71139d authored by Calum Mackay's avatar Calum Mackay Committed by Anna Schumaker
Browse files

SUNRPC: correct error code comment in xs_tcp_setup_socket() 



This comment was introduced by commit 6ea44adc
("SUNRPC: ensure correct error is reported by xs_tcp_setup_socket()").

I believe EIO was a typo at the time: it should have been EAGAIN.

Subsequently, commit 0445f92c ("SUNRPC: Fix disconnection races")
changed that to ENOTCONN.

Rather than trying to keep the comment here in sync with the code in
xprt_force_disconnect(), make the point in a non-specific way.

Fixes: 6ea44adc ("SUNRPC: ensure correct error is reported by xs_tcp_setup_socket()")
Signed-off-by: default avatarCalum Mackay <calum.mackay@oracle.com>
Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
parent 1048ba83

net/sunrpc/xprtsock.c

+2 −4
Original line number Diff line number Diff line
@@ -2276,10 +2276,8 @@ static void xs_tcp_setup_socket(struct work_struct *work) 
	case -EHOSTUNREACH:

	case -EADDRINUSE:

	case -ENOBUFS:

		/*

		 * xs_tcp_force_close() wakes tasks with -EIO.

		 * We need to wake them first to ensure the

		 * correct error code.

		/* xs_tcp_force_close() wakes tasks with a fixed error code.

		 * We need to wake them first to ensure the correct error code.

		 */

		xprt_wake_pending_tasks(xprt, status);

		xs_tcp_force_close(xprt);