Commit 8c817eb2 authored by Shannon Nelson's avatar Shannon Nelson Committed by Jakub Kicinski
Browse files

pds_core: limit loop over fw name list 



Add an array size limit to the for-loop to be sure we don't try
to reference a fw_version string off the end of the fw info names
array.  We know that our firmware only has a limited number
of firmware slot names, but we shouldn't leave this unchecked.

Fixes: 45d76f49 ("pds_core: set up device and adminq")
Signed-off-by: default avatarShannon Nelson <shannon.nelson@amd.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Reviewed-by: default avatarBrett Creeley <brett.creeley@amd.com>
Reviewed-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20250103195147.7408-1-shannon.nelson@amd.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 8ce4f287

drivers/net/ethernet/amd/pds_core/devlink.c

+1 −1
Original line number Diff line number Diff line
@@ -118,7 +118,7 @@ int pdsc_dl_info_get(struct devlink *dl, struct devlink_info_req *req, 
	if (err && err != -EIO)

		return err;



	listlen = fw_list.num_fw_slots;

	listlen = min(fw_list.num_fw_slots, ARRAY_SIZE(fw_list.fw_names));

	for (i = 0; i < listlen; i++) {

		if (i < ARRAY_SIZE(fw_slotnames))

			strscpy(buf, fw_slotnames[i], sizeof(buf));