Commit 8c9aa6e1 authored by Raag Jadav's avatar Raag Jadav Committed by Greg Kroah-Hartman
Browse files

serial: 8250_lpss: copy dma_param using devm_kmemdup() 



Use devm_kmemdup() helper to copy dma_param instead of doing it manually.

Signed-off-by: default avatarRaag Jadav <raag.jadav@intel.com>
Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Link: https://lore.kernel.org/r/20240102055006.27256-1-raag.jadav@intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9903f2f2

drivers/tty/serial/8250/8250_lpss.c

+2 −5
Original line number Diff line number Diff line
@@ -287,17 +287,14 @@ static int lpss8250_dma_setup(struct lpss8250 *lpss, struct uart_8250_port *port 
		return 0;

	}



	rx_param = devm_kzalloc(dev, sizeof(*rx_param), GFP_KERNEL);

	rx_param = devm_kmemdup(dev, &lpss->dma_param, sizeof(*rx_param), GFP_KERNEL);

	if (!rx_param)

		return -ENOMEM;



	tx_param = devm_kzalloc(dev, sizeof(*tx_param), GFP_KERNEL);

	tx_param = devm_kmemdup(dev, &lpss->dma_param, sizeof(*tx_param), GFP_KERNEL);

	if (!tx_param)

		return -ENOMEM;



	*rx_param = lpss->dma_param;

	*tx_param = lpss->dma_param;



	dma->fn = lpss8250_dma_filter;

	dma->rx_param = rx_param;

	dma->tx_param = tx_param;