Commit 8c9b406f authored by Kevin Paul Reddy Janagari's avatar Kevin Paul Reddy Janagari Committed by Paolo Abeni
Browse files

tipc: Removing deprecated strncpy() 



This patch suggests the replacement of strncpy with strscpy
as per Documentation/process/deprecated.
The strncpy() fails to guarantee NULL termination,
The function adds zero pads which isn't really convenient for short strings
as it may cause performance issues.

strscpy() is a preferred replacement because
it overcomes the limitations of strncpy mentioned above.

Compile Tested

Signed-off-by: default avatarKevin Paul Reddy Janagari <kevinpaul468@gmail.com>
Reviewed-by: default avatarTung Nguyen <tung.quang.nguyen@est.tech>
Tested-by: default avatarTung Nguyen <tung.quang.nguyen@est.tech>
Link: https://patch.msgid.link/20250411085010.6249-1-kevinpaul468@gmail.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 4c2e0b00

net/tipc/link.c

+1 −1
Original line number Diff line number Diff line
@@ -2228,7 +2228,7 @@ static int tipc_link_proto_rcv(struct tipc_link *l, struct sk_buff *skb, 
			break;

		if (msg_data_sz(hdr) < TIPC_MAX_IF_NAME)

			break;

		strncpy(if_name, data, TIPC_MAX_IF_NAME);

		strscpy(if_name, data, TIPC_MAX_IF_NAME);



		/* Update own tolerance if peer indicates a non-zero value */

		if (tipc_in_range(peers_tol, TIPC_MIN_LINK_TOL, TIPC_MAX_LINK_TOL)) {

net/tipc/node.c

+1 −1
Original line number Diff line number Diff line
@@ -1581,7 +1581,7 @@ int tipc_node_get_linkname(struct net *net, u32 bearer_id, u32 addr, 
	tipc_node_read_lock(node);

	link = node->links[bearer_id].link;

	if (link) {

		strncpy(linkname, tipc_link_name(link), len);

		strscpy(linkname, tipc_link_name(link), len);

		err = 0;

	}

	tipc_node_read_unlock(node);