Commit 8cbe5649 authored by Thorsten Blum's avatar Thorsten Blum Committed by Takashi Iwai
Browse files

ALSA: intel_hdmi: Fix off-by-one error in __hdmi_lpe_audio_probe() 



In __hdmi_lpe_audio_probe(), strscpy() is incorrectly called with the
length of the source string (excluding the NUL terminator) rather than
the size of the destination buffer. This results in one character less
being copied from 'card->shortname' to 'pcm->name'.

Use the destination buffer size instead to ensure the card name is
copied correctly.

Cc: stable@vger.kernel.org
Fixes: 75b1a8f9 ("ALSA: Convert strlcpy to strscpy when return value is unused")
Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Link: https://patch.msgid.link/20250805234156.60294-1-thorsten.blum@linux.dev


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent dbe05428

sound/x86/intel_hdmi_audio.c

+1 −1
Original line number Diff line number Diff line
@@ -1765,7 +1765,7 @@ static int __hdmi_lpe_audio_probe(struct platform_device *pdev) 
		/* setup private data which can be retrieved when required */

		pcm->private_data = ctx;

		pcm->info_flags = 0;

		strscpy(pcm->name, card->shortname, strlen(card->shortname));

		strscpy(pcm->name, card->shortname, sizeof(pcm->name));

		/* setup the ops for playback */

		snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &had_pcm_ops);