Commit 8cf1e309 authored by Breno Leitao's avatar Breno Leitao Committed by Jakub Kicinski
Browse files

ipv6: Use nlmsg_payload in inet6_rtm_valid_getaddr_req 



Leverage the new nlmsg_payload() helper to avoid checking for message
size and then reading the nlmsg data.

Signed-off-by: default avatarBreno Leitao <leitao@debian.org>
Reviewed-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Link: https://patch.msgid.link/20250414-nlmsg-v2-7-3d90cb42c6af@debian.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent e87187df

net/ipv6/addrconf.c

+2 −2
Original line number Diff line number Diff line
@@ -5484,7 +5484,8 @@ static int inet6_rtm_valid_getaddr_req(struct sk_buff *skb, 
	struct ifaddrmsg *ifm;

	int i, err;



	if (nlh->nlmsg_len < nlmsg_msg_size(sizeof(*ifm))) {

	ifm = nlmsg_payload(nlh, sizeof(*ifm));

	if (!ifm) {

		NL_SET_ERR_MSG_MOD(extack, "Invalid header for get address request");

		return -EINVAL;

	}
@@ -5493,7 +5494,6 @@ static int inet6_rtm_valid_getaddr_req(struct sk_buff *skb, 
		return nlmsg_parse_deprecated(nlh, sizeof(*ifm), tb, IFA_MAX,

					      ifa_ipv6_policy, extack);



	ifm = nlmsg_data(nlh);

	if (ifm->ifa_prefixlen || ifm->ifa_flags || ifm->ifa_scope) {

		NL_SET_ERR_MSG_MOD(extack, "Invalid values in header for get address request");

		return -EINVAL;