Commit 8d2aeab4 authored by Russell King (Oracle)'s avatar Russell King (Oracle) Committed by Paolo Abeni
Browse files

net: pcs: xpcs: remove switch() in xpcs_link_up_1000basex() 



Remove an unnecessary switch() statement in xpcs_link_up_1000basex().
The only value this switch statement is interested in is SPEED_1000,
all other values lead to an error. Replace this with a simple if()
statement.

Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Tested-by: default avatarSerge Semin <fancer.lancer@gmail.com>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 1d2709d6

drivers/net/pcs/pcs-xpcs.c

+3 −8
Original line number Diff line number Diff line
@@ -1127,18 +1127,13 @@ static void xpcs_link_up_1000basex(struct dw_xpcs *xpcs, unsigned int neg_mode, 
	if (neg_mode == PHYLINK_PCS_NEG_INBAND_ENABLED)

		return;



	switch (speed) {

	case SPEED_1000:

		val = BMCR_SPEED1000;

		break;

	case SPEED_100:

	case SPEED_10:

	default:

		dev_err(&xpcs->mdiodev->dev, "%s: speed = %d\n",

	if (speed != SPEED_1000) {

		dev_err(&xpcs->mdiodev->dev, "%s: speed %dMbps not supported\n",

			__func__, speed);

		return;

	}



	val = BMCR_SPEED1000;

	if (duplex == DUPLEX_FULL)

		val |= BMCR_FULLDPLX;

	else