Commit 8d60141a authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

ethtool: rss: fix falsely ignoring indir table updates 

rss_set_prep_indir() compares the new indirection table against the
current one to determine whether any update is needed. The memcmp
call passes data->indir_size as the length argument, but indir_size
is the number of u32 entries, not the byte count.

Fixes: c0ae0358 ("ethtool: rss: initial RSS_SET (indirection table handling)")
Link: https://patch.msgid.link/20260522230647.1705600-4-kuba@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 3e6c6e97

net/ethtool/rss.c

+1 −1
Original line number Diff line number Diff line
@@ -686,7 +686,7 @@ rss_set_prep_indir(struct net_device *dev, struct genl_info *info, 
				ethtool_rxfh_indir_default(i, num_rx_rings);

	}



	*mod |= memcmp(rxfh->indir, data->indir_table, data->indir_size);

	*mod |= memcmp(rxfh->indir, data->indir_table, alloc_size);



	return user_size;