Commit 8dbc2cca authored by Colin Ian King's avatar Colin Ian King Committed by Alex Deucher
Browse files

drm/radeon: fix copy of uninitialized variable back to userspace 



Currently the ioctl command RADEON_INFO_SI_BACKEND_ENABLED_MASK can
copy back uninitialised data in value_tmp that pointer *value points
to. This can occur when rdev->family is less than CHIP_BONAIRE and
less than CHIP_TAHITI.  Fix this by adding in a missing -EINVAL
so that no invalid value is copied back to userspace.

Addresses-Coverity: ("Uninitialized scalar variable)
Cc: stable@vger.kernel.org # 3.13+
Fixes: 439a1cff ("drm/radeon: expose render backend mask to the userspace")
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 147ab7a1

drivers/gpu/drm/radeon/radeon_kms.c

+1 −0
Original line number Diff line number Diff line
@@ -518,6 +518,7 @@ int radeon_info_ioctl(struct drm_device *dev, void *data, struct drm_file *filp) 
			*value = rdev->config.si.backend_enable_mask;

		} else {

			DRM_DEBUG_KMS("BACKEND_ENABLED_MASK is si+ only!\n");

			return -EINVAL;

		}

		break;

	case RADEON_INFO_MAX_SCLK: