Commit 8de4e0f4 authored by Felix Gu's avatar Felix Gu Committed by Bartosz Golaszewski
Browse files

gpio: qixis-fpga: Fix error handling for devm_regmap_init_mmio() 



devm_regmap_init_mmio() returns an ERR_PTR() on failure, not NULL.
The original code checked for NULL which would never trigger on error,
potentially leading to an invalid pointer dereference.
Use IS_ERR() and PTR_ERR() to properly handle the error case.

Fixes: e8850024 ("gpio: add QIXIS FPGA GPIO controller")
Signed-off-by: default avatarFelix Gu <ustc.gu@gmail.com>
Link: https://patch.msgid.link/20260320-qixis-v1-1-a8efc22e8945@gmail.com


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
parent ec42a3a9

drivers/gpio/gpio-qixis-fpga.c

+2 −2
Original line number Diff line number Diff line
@@ -60,8 +60,8 @@ static int qixis_cpld_gpio_probe(struct platform_device *pdev) 
			return PTR_ERR(reg);



		regmap = devm_regmap_init_mmio(&pdev->dev, reg, &regmap_config_8r_8v);

		if (!regmap)

			return -ENODEV;

		if (IS_ERR(regmap))

			return PTR_ERR(regmap);



		/* In this case, the offset of our register is 0 inside the

		 * regmap area that we just created.