Commit 8ded03ae authored by Nathan Lynch's avatar Nathan Lynch Committed by Michael Ellerman
Browse files

powerpc/pseries/papr-sysparm: use u8 arrays for payloads 



Some PAPR system parameter values are formatted by firmware as
nul-terminated strings (e.g. LPAR name, shared processor attributes).
But the values returned for other parameters, such as processor module
info and TLB block invalidate characteristics, are binary data with
parameter-specific layouts. So char[] isn't the appropriate type for
the general case. Use u8/__u8.

Signed-off-by: default avatarNathan Lynch <nathanl@linux.ibm.com>
Fixes: 905b9e48 ("powerpc/pseries/papr-sysparm: Expose character device to user space")
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20240202-papr-sysparm-ioblock-data-use-u8-v1-1-f5c6c89f65ec@linux.ibm.com
parent 41bccc98

arch/powerpc/include/asm/papr-sysparm.h

+1 −1
Original line number Diff line number Diff line
@@ -32,7 +32,7 @@ typedef struct { 
 */

struct papr_sysparm_buf {

	__be16 len;

	char val[PAPR_SYSPARM_MAX_OUTPUT];

	u8 val[PAPR_SYSPARM_MAX_OUTPUT];

};



struct papr_sysparm_buf *papr_sysparm_buf_alloc(void);

arch/powerpc/include/uapi/asm/papr-sysparm.h

+1 −1
Original line number Diff line number Diff line
@@ -14,7 +14,7 @@ enum { 
struct papr_sysparm_io_block {

	__u32 parameter;

	__u16 length;

	char data[PAPR_SYSPARM_MAX_OUTPUT];

	__u8 data[PAPR_SYSPARM_MAX_OUTPUT];

};



/**