Unverified Commit 8e0a2fc6 authored by Srinivas Pandruvada's avatar Srinivas Pandruvada Committed by Ilpo Järvinen
Browse files

platform/x86/intel/tpmi: Use 32 bit aligned address for debugfs mem write 



The memory write feature supports 32-bit writes to any TPMI offset.
However, future hardware generations may not allow writes to non-32-bit
aligned addresses due to hardware optimizations.

Since all TPMI addresses are 64-bit aligned and correspond to 64-bit
registers, enforce 32-bit alignment for write operations.

Signed-off-by: default avatarSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Link: https://patch.msgid.link/20260326182446.3478672-1-srinivas.pandruvada@linux.intel.com


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent 9ec6bf62

drivers/platform/x86/intel/vsec_tpmi.c

+4 −0
Original line number Diff line number Diff line
@@ -46,6 +46,7 @@ 
 * provided by the Intel VSEC driver.

 */



#include <linux/align.h>

#include <linux/auxiliary_bus.h>

#include <linux/bitfield.h>

#include <linux/debugfs.h>
@@ -479,6 +480,9 @@ static ssize_t mem_write(struct file *file, const char __user *userbuf, size_t l 
	addr = array[2];

	value = array[3];



	if (!IS_ALIGNED(addr, sizeof(u32)))

		return -EINVAL;



	if (punit >= pfs->pfs_header.num_entries) {

		ret = -EINVAL;

		goto exit_write;