Commit 8e246a1b authored by Ian Rogers's avatar Ian Rogers Committed by Arnaldo Carvalho de Melo
Browse files

perf inject: Fix use without initialization of local variables 



Local variables were missing initialization and command line
processing didn't provide default values.

Fixes: 64eed019 ("perf inject: Lazy build-id mmap2 event insertion")
Reviewed-by: default avatarJames Clark <james.clark@linaro.org>
Signed-off-by: default avatarIan Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20241211060831.806539-1-irogers@google.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 6804a719

tools/perf/builtin-inject.c

+4 −4
Original line number Diff line number Diff line
@@ -2367,10 +2367,10 @@ int cmd_inject(int argc, const char **argv) 
	};

	int ret;

	const char *known_build_ids = NULL;

	bool build_ids;

	bool build_id_all;

	bool mmap2_build_ids;

	bool mmap2_build_id_all;

	bool build_ids = false;

	bool build_id_all = false;

	bool mmap2_build_ids = false;

	bool mmap2_build_id_all = false;



	struct option options[] = {

		OPT_BOOLEAN('b', "build-ids", &build_ids,