Commit 8e370797 authored by Jakub Kicinski's avatar Jakub Kicinski Committed by David S. Miller
Browse files

tools: ynl-gen: always append ULL/LL to range types 



32bit builds generate the following warning when we use a u32-max
in range validation:

  warning: decimal constant 4294967295 is between LONG_MAX and ULONG_MAX. For C99 that means long long, C90 compilers are very likely to produce unsigned long (and a warning) here

The range values are u64, slap ULL/LL on all of them just
to avoid such noise.

There's currently no code using full range validation, but
it will matter in the upcoming page-pool introspection.

Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d1d3470a

tools/net/ynl/ynl-gen-c.py

+3 −2
Original line number Diff line number Diff line
@@ -2070,12 +2070,13 @@ def print_kernel_policy_ranges(family, cw): 
                first = False



            sign = '' if attr.type[0] == 'u' else '_signed'

            suffix = 'ULL' if attr.type[0] == 'u' else 'LL'

            cw.block_start(line=f'static const struct netlink_range_validation{sign} {c_lower(attr.enum_name)}_range =')

            members = []

            if 'min' in attr.checks:

                members.append(('min', attr.get_limit('min')))

                members.append(('min', str(attr.get_limit('min')) + suffix))

            if 'max' in attr.checks:

                members.append(('max', attr.get_limit('max')))

                members.append(('max', str(attr.get_limit('max')) + suffix))

            cw.write_struct_init(members)

            cw.block_end(line=';')

            cw.nl()