Commit 8e3a3e84 authored by Lijo Lazar's avatar Lijo Lazar Committed by Alex Deucher
Browse files

drm/amdgpu: Zero-initialize mqd backup memory 



Zero-initialize mqd backup memory, otherwise the check for
'already-backed-up' could go wrong.

Signed-off-by: default avatarLijo Lazar <lijo.lazar@amd.com>
Reviewed-by: default avatarYang Wang <kevinyang.wang@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 0642c95e

drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c

+3 −3
Original line number Diff line number Diff line
@@ -405,7 +405,7 @@ int amdgpu_gfx_mqd_sw_init(struct amdgpu_device *adev, 
		}



		/* prepare MQD backup */

		kiq->mqd_backup = kmalloc(mqd_size, GFP_KERNEL);

		kiq->mqd_backup = kzalloc(mqd_size, GFP_KERNEL);

		if (!kiq->mqd_backup) {

			dev_warn(adev->dev,

				 "no memory to create MQD backup for ring %s\n", ring->name);
@@ -428,7 +428,7 @@ int amdgpu_gfx_mqd_sw_init(struct amdgpu_device *adev, 


				ring->mqd_size = mqd_size;

				/* prepare MQD backup */

				adev->gfx.me.mqd_backup[i] = kmalloc(mqd_size, GFP_KERNEL);

				adev->gfx.me.mqd_backup[i] = kzalloc(mqd_size, GFP_KERNEL);

				if (!adev->gfx.me.mqd_backup[i]) {

					dev_warn(adev->dev, "no memory to create MQD backup for ring %s\n", ring->name);

					return -ENOMEM;
@@ -452,7 +452,7 @@ int amdgpu_gfx_mqd_sw_init(struct amdgpu_device *adev, 


			ring->mqd_size = mqd_size;

			/* prepare MQD backup */

			adev->gfx.mec.mqd_backup[j] = kmalloc(mqd_size, GFP_KERNEL);

			adev->gfx.mec.mqd_backup[j] = kzalloc(mqd_size, GFP_KERNEL);

			if (!adev->gfx.mec.mqd_backup[j]) {

				dev_warn(adev->dev, "no memory to create MQD backup for ring %s\n", ring->name);

				return -ENOMEM;