Commit 8e3d8b33 authored by Loic Poulain's avatar Loic Poulain Committed by Dmitry Baryshkov
Browse files

drm: bridge: anx7625: don't crash if Type-C port is not used 



The typec_set_*() functions do not tolerate being passed the NULL
typec_port instance. However, if CONFIG_TYPEC is enabled, but anx7625
DT node doesn't have the usb-c connector fwnode, then typec_port remains
NULL, crashing the kernel. Prevent calling typec_set_foo() functions by
checking that ctx->typec_port is not NULL in anx7625_typec_set_status().

 Call trace:
  typec_set_orientation+0x18/0x68 (P)
  anx7625_typec_set_status+0x108/0x13c
  anx7625_work_func+0x124/0x438
  process_one_work+0x214/0x648
  worker_thread+0x1b4/0x358
  kthread+0x14c/0x214
  ret_from_fork+0x10/0x20
 Code: 910003fd a90153f3 aa0003f3 2a0103f4 (f9431400)

Fixes: f81455b2 ("drm: bridge: anx7625: implement minimal Type-C support")
Reported-by: default avatarSalendarsingh Gaud <sgaud@qti.qualcomm.com>
Signed-off-by: default avatarLoic Poulain <loic.poulain@oss.qualcomm.com>
[db: dropped chunk anx7625_typec_unregister(), wrote commit message]
Cc: Amit Kucheria <akucheri@qti.qualcomm.com>
Reviewed-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Link: https://patch.msgid.link/20260215-anx-fix-no-typec-v1-1-75172a5ca88b@oss.qualcomm.com


Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
parent 10e9ff46

drivers/gpu/drm/bridge/analogix/anx7625.c

+3 −0
Original line number Diff line number Diff line
@@ -1566,6 +1566,9 @@ static void anx7625_typec_set_status(struct anx7625_data *ctx, 
				     unsigned int intr_status,

				     unsigned int intr_vector)

{

	if (!ctx->typec_port)

		return;



	if (intr_vector & CC_STATUS)

		anx7625_typec_set_orientation(ctx);

	if (intr_vector & DATA_ROLE_STATUS) {