Commit 8ed90e37 authored by Ming Lei's avatar Ming Lei Committed by Jens Axboe
Browse files

ublk: don't get ublk device reference in ublk_abort_queue() 



ublk_abort_queue() is called in ublk_daemon_monitor_work(), in which
it is guaranteed that the device is live because monitor work is
canceled when removing device, so no need to get the device reference.

Signed-off-by: default avatarMing Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20231009093324.957829-2-ming.lei@redhat.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 6eba24ae

drivers/block/ublk_drv.c

+0 −4
Original line number Diff line number Diff line
@@ -1420,9 +1420,6 @@ static void ublk_abort_queue(struct ublk_device *ub, struct ublk_queue *ubq) 
{

	int i;



	if (!ublk_get_device(ub))

		return;



	for (i = 0; i < ubq->q_depth; i++) {

		struct ublk_io *io = &ubq->ios[i];
@@ -1438,7 +1435,6 @@ static void ublk_abort_queue(struct ublk_device *ub, struct ublk_queue *ubq) 
				__ublk_fail_req(ubq, io, rq);

		}

	}

	ublk_put_device(ub);

}



static void ublk_daemon_monitor_work(struct work_struct *work)