Commit 8edd00b0 authored by Conor Dooley's avatar Conor Dooley Committed by Jassi Brar
Browse files

dt-bindings: mailbox: mpfs: fix reg properties



When the binding for this was originally written, and later modified,
mistakes were made - and the precise nature of the later modification
should have been a giveaway, but alas I was naive at the time.

A more correct modelling of the hardware is to use two syscons and have
a single reg entry for the mailbox, containing the mailbox region. The
two syscons contain the general control/status registers for the mailbox
and the interrupt related registers respectively. The reason for two
syscons is that the same mailbox is present on the non-SoC version of
the FPGA, which has no interrupt controller, and the shared part of the
rtl was unchanged between devices.

This is now coming to a head, because the control/status registers share
a register region with the "tvs" (temperature & voltage sensors)
registers and, as it turns out, people do want to monitor temperatures
and voltages...

Signed-off-by: default avatarConor Dooley <conor.dooley@microchip.com>
Acked-by: default avatarRob Herring (Arm) <robh@kernel.org>
Signed-off-by: default avatarJassi Brar <jassisinghbrar@gmail.com>
parent 2d5404ca
Loading
Loading
Loading
Loading
+8 −5
Original line number Diff line number Diff line
@@ -15,6 +15,8 @@ properties:

  reg:
    oneOf:
      - items:
          - description: mailbox data registers
      - items:
          - description: mailbox control & data registers
          - description: mailbox interrupt registers
@@ -23,6 +25,7 @@ properties:
          - description: mailbox control registers
          - description: mailbox interrupt registers
          - description: mailbox data registers
        deprecated: true

  interrupts:
    maxItems: 1
@@ -41,12 +44,12 @@ additionalProperties: false
examples:
  - |
    soc {
      #address-cells = <2>;
      #size-cells = <2>;
      mbox: mailbox@37020000 {
      #address-cells = <1>;
      #size-cells = <1>;

      mailbox@37020800 {
        compatible = "microchip,mpfs-mailbox";
        reg = <0x0 0x37020000 0x0 0x58>, <0x0 0x2000318C 0x0 0x40>,
              <0x0 0x37020800 0x0 0x100>;
        reg = <0x37020800 0x100>;
        interrupt-parent = <&L1>;
        interrupts = <96>;
        #mbox-cells = <1>;