Commit 8ee1c926 authored by Russell King (Oracle)'s avatar Russell King (Oracle) Committed by Paolo Abeni
Browse files

net: stmmac: qcom-ethqos: remove of_get_phy_mode() 



devm_stmmac_probe_config_dt() already gets the PHY mode from firmware,
which is stored in plat_dat->phy_interface. Therefore, we don't need to
get it a second time in qcom_ethqos_probe(). Use
plat_dat->phy_interface to initialise ethqos->phy_mode.

Reviewed-by: default avatarMichal Kubiak <michal.kubiak@intel.com>
Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1tsIGI-005uzT-KB@rmk-PC.armlinux.org.uk


Reviewed-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 15492700

drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c

+1 −3
Original line number Diff line number Diff line
@@ -794,9 +794,7 @@ static int qcom_ethqos_probe(struct platform_device *pdev) 
	if (!ethqos)

		return -ENOMEM;



	ret = of_get_phy_mode(np, &ethqos->phy_mode);

	if (ret)

		return dev_err_probe(dev, ret, "Failed to get phy mode\n");

	ethqos->phy_mode = plat_dat->phy_interface;

	switch (ethqos->phy_mode) {

	case PHY_INTERFACE_MODE_RGMII:

	case PHY_INTERFACE_MODE_RGMII_ID: