Commit 8f175272 authored by Zizhi Wo's avatar Zizhi Wo Committed by Steve French
Browse files

ksmbd: fix memory leak in smb2_lock() 



In smb2_lock(), if setup_async_work() executes successfully,
work->cancel_argv will bind the argv that generated by kmalloc(). And
release_async_work() is called in ksmbd_conn_try_dequeue_request() or
smb2_lock() to release argv.
However, when setup_async_work function fails, work->cancel_argv has not
been bound to the argv, resulting in the previously allocated argv not
being released. Call kfree() to fix it.

Fixes: e2f34481 ("cifsd: add server-side procedures for SMB3")
Signed-off-by: default avatarZizhi Wo <wozizhi@huawei.com>
Acked-by: default avatarNamjae Jeon <linkinjeon@kernel.org>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 33cc938e

fs/smb/server/smb2pdu.c

+1 −0
Original line number Diff line number Diff line
@@ -7080,6 +7080,7 @@ int smb2_lock(struct ksmbd_work *work) 
						      smb2_remove_blocked_lock,

						      argv);

				if (rc) {

					kfree(argv);

					err = -ENOMEM;

					goto out;

				}