Commit 8f3d1c9f authored by Dr. David Alan Gilbert's avatar Dr. David Alan Gilbert Committed by Lucas De Marchi
Browse files

drm/xe: Remove unused functions 



xe_bo_create_from_data() last use was removed in 2023 by
commit 0e1a47fc ("drm/xe: Add a helper for DRM device-lifetime BO
create")

xe_rtp_match_first_gslice_fused_off() last use was removed in 2023 by
commit 4e124151 ("drm/xe/dg2: Drop pre-production workarounds")

Remove them, and xe_dss_mask_empty whose last use was by
xe_rtp_match_first_gslice_fused_off().

(Xe has a bunch ofother symbols that have been added but not used,
given how new it is, I've left those, as opposed to these that
had the code that used them removed).

Reviewed-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: default avatarDr. David Alan Gilbert <linux@treblig.org>
Link: https://lore.kernel.org/r/20250713152531.219326-1-linux@treblig.org


Signed-off-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
parent 7b6db173

drivers/gpu/drm/xe/xe_bo.c

+0 −15
Original line number Diff line number Diff line
@@ -2174,21 +2174,6 @@ struct xe_bo *xe_bo_create_pin_map(struct xe_device *xe, struct xe_tile *tile, 
	return xe_bo_create_pin_map_at(xe, tile, vm, size, ~0ull, type, flags);

}



struct xe_bo *xe_bo_create_from_data(struct xe_device *xe, struct xe_tile *tile,

				     const void *data, size_t size,

				     enum ttm_bo_type type, u32 flags)

{

	struct xe_bo *bo = xe_bo_create_pin_map(xe, tile, NULL,

						ALIGN(size, PAGE_SIZE),

						type, flags);

	if (IS_ERR(bo))

		return bo;



	xe_map_memcpy_to(xe, &bo->vmap, 0, data, size);



	return bo;

}



static void __xe_bo_unpin_map_no_vm(void *arg)

{

	xe_bo_unpin_map_no_vm(arg);

drivers/gpu/drm/xe/xe_bo.h

+0 −3
Original line number Diff line number Diff line
@@ -118,9 +118,6 @@ struct xe_bo *xe_bo_create_pin_map_at_aligned(struct xe_device *xe, 
					      size_t size, u64 offset,

					      enum ttm_bo_type type, u32 flags,

					      u64 alignment);

struct xe_bo *xe_bo_create_from_data(struct xe_device *xe, struct xe_tile *tile,

				     const void *data, size_t size,

				     enum ttm_bo_type type, u32 flags);

struct xe_bo *xe_managed_bo_create_pin_map(struct xe_device *xe, struct xe_tile *tile,

					   size_t size, u32 flags);

struct xe_bo *xe_managed_bo_create_from_data(struct xe_device *xe, struct xe_tile *tile,

drivers/gpu/drm/xe/xe_gt_topology.c

+0 −5
Original line number Diff line number Diff line
@@ -290,11 +290,6 @@ xe_dss_mask_group_ffs(const xe_dss_mask_t mask, int groupsize, int groupnum) 
	return find_next_bit(mask, XE_MAX_DSS_FUSE_BITS, groupnum * groupsize);

}



bool xe_dss_mask_empty(const xe_dss_mask_t mask)

{

	return bitmap_empty(mask, XE_MAX_DSS_FUSE_BITS);

}



/**

 * xe_gt_topology_has_dss_in_quadrant - check fusing of DSS in GT quadrant

 * @gt: GT to check

drivers/gpu/drm/xe/xe_gt_topology.h

+0 −2
Original line number Diff line number Diff line
@@ -41,8 +41,6 @@ xe_gt_topology_mask_last_dss(const xe_dss_mask_t mask) 
unsigned int

xe_dss_mask_group_ffs(const xe_dss_mask_t mask, int groupsize, int groupnum);



bool xe_dss_mask_empty(const xe_dss_mask_t mask);



bool

xe_gt_topology_has_dss_in_quadrant(struct xe_gt *gt, int quad);

drivers/gpu/drm/xe/xe_rtp.c

+0 −15
Original line number Diff line number Diff line
@@ -358,21 +358,6 @@ bool xe_rtp_match_first_render_or_compute(const struct xe_gt *gt, 
		hwe->engine_id == __ffs(render_compute_mask);

}



bool xe_rtp_match_first_gslice_fused_off(const struct xe_gt *gt,

					 const struct xe_hw_engine *hwe)

{

	unsigned int dss_per_gslice = 4;

	unsigned int dss;



	if (drm_WARN(&gt_to_xe(gt)->drm, xe_dss_mask_empty(gt->fuse_topo.g_dss_mask),

		     "Checking gslice for platform without geometry pipeline\n"))

		return false;



	dss = xe_dss_mask_group_ffs(gt->fuse_topo.g_dss_mask, 0, 0);



	return dss >= dss_per_gslice;

}



bool xe_rtp_match_not_sriov_vf(const struct xe_gt *gt,

			       const struct xe_hw_engine *hwe)

{