Commit 8f9f64c8 authored by Luca Leonardo Scorcia's avatar Luca Leonardo Scorcia Committed by Linus Walleij
Browse files

pinctrl: mediatek: common: Fix probe failure for devices without EINT 



Some pinctrl devices like mt6397 or mt6392 don't support EINT at all, but
the mtk_eint_init function is always called and returns -ENODEV, which
then bubbles up and causes probe failure.

To address this only call mtk_eint_init if EINT pins are present.

Tested on Xiaomi Mi Smart Clock x04g (mt6392).

Fixes: e46df235 ("pinctrl: mediatek: refactor EINT related code for all MediaTek pinctrl can fit")
Signed-off-by: default avatarLuca Leonardo Scorcia <l.scorcia@gmail.com>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: default avatarLinus Walleij <linusw@kernel.org>
parent c8cfeb4b

drivers/pinctrl/mediatek/pinctrl-mtk-common.c

+6 −3
Original line number Diff line number Diff line
@@ -1135,9 +1135,12 @@ int mtk_pctrl_init(struct platform_device *pdev, 
		goto chip_error;

	}



	/* Only initialize EINT if we have EINT pins */

	if (data->eint_hw.ap_num > 0) {

		ret = mtk_eint_init(pctl, pdev);

		if (ret)

			goto chip_error;

	}



	return 0;