Commit 8fc80c9d authored by Russell King (Oracle)'s avatar Russell King (Oracle) Committed by Jakub Kicinski
Browse files

net: phy: marvell: add comment about m88e1111_config_init_1000basex() 



The comment in m88e1111_config_init_1000basex() is wrong - it claims
that Autoneg will be enabled, but this doesn't actually happen.

Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/E1rhos4-003yuQ-5p@rmk-PC.armlinux.org.uk


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 02e24903

drivers/net/phy/marvell.c

+4 −1
Original line number Diff line number Diff line
@@ -919,7 +919,10 @@ static int m88e1111_config_init_1000basex(struct phy_device *phydev) 
	if (extsr < 0)

		return extsr;



	/* If using copper mode, ensure 1000BaseX auto-negotiation is enabled */

	/* If using copper mode, ensure 1000BaseX auto-negotiation is enabled.

	 * FIXME: this does not actually enable 1000BaseX auto-negotiation if

	 * it was previously disabled in the Fiber BMCR!

	 */

	mode = extsr & MII_M1111_HWCFG_MODE_MASK;

	if (mode == MII_M1111_HWCFG_MODE_COPPER_1000X_NOAN) {

		err = phy_modify(phydev, MII_M1111_PHY_EXT_SR,