Commit 8fc9a77b authored by Sergey Shtylyov's avatar Sergey Shtylyov Committed by Ulf Hansson
Browse files

mmc: meson-mx-sdio: add IRQ check 



The driver neglects to check the result of platform_get_irq()'s call and
blithely passes the negative error codes to devm_request_threaded_irq()
(which takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding
an original error code. Stop calling devm_request_threaded_irq() with the
invalid IRQ #s.

Fixes: ed80a13b ("mmc: meson-mx-sdio: Add a driver for the Amlogic Meson8 and Meson8b SoC")
Signed-off-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
Reviewed-by: default avatarMartin Blumenstingl <martin.blumenstingl@googlemail.com>
Link: https://lore.kernel.org/r/20211217202717.10041-3-s.shtylyov@omp.ru


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 77bed755

drivers/mmc/host/meson-mx-sdio.c

+5 −0
Original line number Diff line number Diff line
@@ -662,6 +662,11 @@ static int meson_mx_mmc_probe(struct platform_device *pdev) 
	}



	irq = platform_get_irq(pdev, 0);

	if (irq < 0) {

		ret = irq;

		goto error_free_mmc;

	}



	ret = devm_request_threaded_irq(host->controller_dev, irq,

					meson_mx_mmc_irq,

					meson_mx_mmc_irq_thread, IRQF_ONESHOT,