Commit 8fee6d5a authored by Bence Csókás's avatar Bence Csókás Committed by Jakub Kicinski
Browse files

net: fec: Stop PPS on driver remove 



PPS was not stopped in `fec_ptp_stop()`, called when
the adapter was removed. Consequentially, you couldn't
safely reload the driver with the PPS signal on.

Fixes: 32cba57b ("net: fec: introduce fec_ptp_stop and use in probe fail path")
Reviewed-by: default avatarFabio Estevam <festevam@gmail.com>
Link: https://lore.kernel.org/netdev/CAOMZO5BzcZR8PwKKwBssQq_wAGzVgf1ffwe_nhpQJjviTdxy-w@mail.gmail.com/T/#m01dcb810bfc451a492140f6797ca77443d0cb79f


Signed-off-by: default avatarCsókás, Bence <csokas.bence@prolan.hu>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Reviewed-by: default avatarFrank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/20240807080956.2556602-1-csokas.bence@prolan.hu


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 9ee09edc

drivers/net/ethernet/freescale/fec_ptp.c

+3 −0
Original line number Diff line number Diff line
@@ -775,6 +775,9 @@ void fec_ptp_stop(struct platform_device *pdev) 
	struct net_device *ndev = platform_get_drvdata(pdev);

	struct fec_enet_private *fep = netdev_priv(ndev);



	if (fep->pps_enable)

		fec_ptp_enable_pps(fep, 0);



	cancel_delayed_work_sync(&fep->time_keep);

	hrtimer_cancel(&fep->perout_timer);

	if (fep->ptp_clock)