Unverified Commit 8ff4574c authored by Guilherme Giacomo Simoes's avatar Guilherme Giacomo Simoes Committed by Krzysztof Wilczyński
Browse files

PCI: cpcihp: Remove unused .get_power() and .set_power() 

The .get_power() and .set_power() function pointers in struct
cpci_hp_controller_ops were declared but never implemented by any
driver.

Thus, to improve code readability and reduce resource usage,
remove these pointers and the code that has never been used.

Link: https://lore.kernel.org/r/20250217185638.398925-1-trintaeoitogc@gmail.com


Signed-off-by: default avatarGuilherme Giacomo Simoes <trintaeoitogc@gmail.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
[kwilczynski: commit log]
Signed-off-by: default avatarKrzysztof Wilczyński <kwilczynski@kernel.org>
parent 588021b2

drivers/pci/hotplug/cpci_hotplug.h

+0 −2
Original line number Diff line number Diff line
@@ -44,8 +44,6 @@ struct cpci_hp_controller_ops { 
	int (*enable_irq)(void);

	int (*disable_irq)(void);

	int (*check_irq)(void *dev_id);

	u8  (*get_power)(struct slot *slot);

	int (*set_power)(struct slot *slot, int value);

};



struct cpci_hp_controller {

drivers/pci/hotplug/cpci_hotplug_core.c

+2 −15
Original line number Diff line number Diff line
@@ -71,13 +71,10 @@ static int 
enable_slot(struct hotplug_slot *hotplug_slot)

{

	struct slot *slot = to_slot(hotplug_slot);

	int retval = 0;



	dbg("%s - physical_slot = %s", __func__, slot_name(slot));



	if (controller->ops->set_power)

		retval = controller->ops->set_power(slot, 1);

	return retval;

	return 0;

}



static int
@@ -109,12 +106,6 @@ disable_slot(struct hotplug_slot *hotplug_slot) 
	}

	cpci_led_on(slot);



	if (controller->ops->set_power) {

		retval = controller->ops->set_power(slot, 0);

		if (retval)

			goto disable_error;

	}



	slot->adapter_status = 0;



	if (slot->extracting) {
@@ -129,11 +120,7 @@ disable_slot(struct hotplug_slot *hotplug_slot) 
static u8

cpci_get_power_status(struct slot *slot)

{

	u8 power = 1;



	if (controller->ops->get_power)

		power = controller->ops->get_power(slot);

	return power;

	return 1;

}



static int