Commit 903238a3 authored by Dmitry Baryshkov's avatar Dmitry Baryshkov Committed by Daniel Lezcano
Browse files

thermal/drivers/tsens: limit num_sensors to 9 for msm8939 



On msm8939 last (hwid=10) sensor was added in the hw revision 3.0.
Calibration data for it was placed outside of the main calibration data
blob, so it is not accessible by the current blob-parsing code.

Moreover data for the sensor's p2 is not contiguous in the fuses. This
makes it hard to use nvmem_cell API to parse calibration data in a
generic way.

Since the sensor doesn't seem to be actually used by the existing
hardware, disable the sensor for now.

Fixes: 332bc8eb ("thermal: qcom: tsens-v0_1: Add support for MSM8939")
Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Shawn Guo <shawn.guo@linaro.org>
Acked-by: default avatarShawn Guo <shawn.guo@linaro.org>
Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: default avatarBryan O'Donoghue <bryan.odonoghue@linaro.org>
Link: https://lore.kernel.org/r/20230101194034.831222-9-dmitry.baryshkov@linaro.org


Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
parent 5aec3b03

drivers/thermal/qcom/tsens-v0_1.c

+4 −9
Original line number Diff line number Diff line
@@ -285,7 +285,7 @@ static int calibrate_8939(struct tsens_priv *priv) 
	u32 p1[10], p2[10];

	int mode = 0;

	u32 *qfprom_cdata;

	u32 cdata[6];

	u32 cdata[4];



	qfprom_cdata = (u32 *)qfprom_read(priv->dev, "calib");

	if (IS_ERR(qfprom_cdata))
@@ -296,8 +296,6 @@ static int calibrate_8939(struct tsens_priv *priv) 
	cdata[1] = qfprom_cdata[13];

	cdata[2] = qfprom_cdata[0];

	cdata[3] = qfprom_cdata[1];

	cdata[4] = qfprom_cdata[22];

	cdata[5] = qfprom_cdata[21];



	mode = (cdata[0] & MSM8939_CAL_SEL_MASK) >> MSM8939_CAL_SEL_SHIFT;

	dev_dbg(priv->dev, "calibration mode is %d\n", mode);
@@ -314,8 +312,6 @@ static int calibrate_8939(struct tsens_priv *priv) 
		p2[6] = (cdata[2] & MSM8939_S6_P2_MASK) >> MSM8939_S6_P2_SHIFT;

		p2[7] = (cdata[3] & MSM8939_S7_P2_MASK) >> MSM8939_S7_P2_SHIFT;

		p2[8] = (cdata[3] & MSM8939_S8_P2_MASK) >> MSM8939_S8_P2_SHIFT;

		p2[9] = (cdata[4] & MSM8939_S9_P2_MASK_0_4) >> MSM8939_S9_P2_SHIFT_0_4;

		p2[9] |= ((cdata[5] & MSM8939_S9_P2_MASK_5) >> MSM8939_S9_P2_SHIFT_5) << 5;

		for (i = 0; i < priv->num_sensors; i++)

			p2[i] = (base1 + p2[i]) << 2;

		fallthrough;
@@ -331,7 +327,6 @@ static int calibrate_8939(struct tsens_priv *priv) 
		p1[6] = (cdata[2] & MSM8939_S6_P1_MASK) >> MSM8939_S6_P1_SHIFT;

		p1[7] = (cdata[3] & MSM8939_S7_P1_MASK) >> MSM8939_S7_P1_SHIFT;

		p1[8] = (cdata[3] & MSM8939_S8_P1_MASK) >> MSM8939_S8_P1_SHIFT;

		p1[9] = (cdata[4] & MSM8939_S9_P1_MASK) >> MSM8939_S9_P1_SHIFT;

		for (i = 0; i < priv->num_sensors; i++)

			p1[i] = ((base0) + p1[i]) << 2;

		break;
@@ -544,7 +539,7 @@ static int __init init_8939(struct tsens_priv *priv) { 
	priv->sensor[6].slope = 2833;

	priv->sensor[7].slope = 2838;

	priv->sensor[8].slope = 2840;

	priv->sensor[9].slope = 2852;

	/* priv->sensor[9].slope = 2852; */



	return init_common(priv);

}
@@ -620,9 +615,9 @@ static const struct tsens_ops ops_8939 = { 
};



struct tsens_plat_data data_8939 = {

	.num_sensors	= 10,

	.num_sensors	= 9,

	.ops		= &ops_8939,

	.hw_ids		= (unsigned int []){ 0, 1, 2, 3, 5, 6, 7, 8, 9, 10 },

	.hw_ids		= (unsigned int []){ 0, 1, 2, 3, 5, 6, 7, 8, 9, /* 10 */ },



	.feat		= &tsens_v0_1_feat,

	.fields	= tsens_v0_1_regfields,