Commit 9032f767 authored by D. Wythe's avatar D. Wythe Committed by Jakub Kicinski
Browse files

net/smc: fix missing sk_err when TCP handshake fails 



In smc_connect_work(), when the underlying TCP handshake fails, the error
code (rc) must be propagated to sk_err to ensure userspace can correctly
retrieve the error status via SO_ERROR. Currently, the code only handles
a restricted set of error codes (e.g., EPIPE, ECONNREFUSED). If other
errors occurs, such as EHOSTUNREACH, sk_err remains unset (zero).

This affects applications that rely on SO_ERROR to determine connect
outcome. For example, higher versions of Go's netpoller treats
SO_ERROR == 0 combined with a failed getpeername() as a spurious wakeup
and re-enters epoll_wait(). Under ET mode, no further edge will be
generated since the socket is already in a terminal state, causing the
connect to hang indefinitely or until a user-specified timeout, if one
is set.

Fixes: 50717a37 ("net/smc: nonblocking connect rework")
Signed-off-by: default avatarD. Wythe <alibuda@linux.alibaba.com>
Reviewed-by: default avatarDust Li <dust.li@linux.alibaba.com>
Link: https://patch.msgid.link/20260506014105.27093-1-alibuda@linux.alibaba.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent d119775f

net/smc/af_smc.c

+2 −6
Original line number Diff line number Diff line
@@ -1628,12 +1628,8 @@ static void smc_connect_work(struct work_struct *work) 
	lock_sock(&smc->sk);

	if (rc != 0 || smc->sk.sk_err) {

		smc->sk.sk_state = SMC_CLOSED;

		if (rc == -EPIPE || rc == -EAGAIN)

			smc->sk.sk_err = EPIPE;

		else if (rc == -ECONNREFUSED)

			smc->sk.sk_err = ECONNREFUSED;

		else if (signal_pending(current))

			smc->sk.sk_err = -sock_intr_errno(timeo);

		if (!smc->sk.sk_err)

			smc->sk.sk_err = (rc == -EAGAIN) ? EPIPE : -rc;

		sock_put(&smc->sk); /* passive closing */

		goto out;

	}