Commit 9046d581 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Jakub Kicinski
Browse files

enetc: avoid truncating error message 



As clang points out, the error message in enetc_setup_xdp_prog()
still does not fit in the buffer and will be truncated:

drivers/net/ethernet/freescale/enetc/enetc.c:2771:3: error: 'snprintf' will always be truncated; specified size is 80, but format string expands to at least 87 [-Werror,-Wformat-truncation]

Replace it with an even shorter message that should fit.

Fixes: f968c564 ("net: enetc: shorten enetc_setup_xdp_prog() error message to fit NETLINK_MAX_FMTMSG_LEN")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20240326223825.4084412-3-arnd@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent b6694abc

drivers/net/ethernet/freescale/enetc/enetc.c

+1 −1
Original line number Diff line number Diff line
@@ -2769,7 +2769,7 @@ static int enetc_setup_xdp_prog(struct net_device *ndev, struct bpf_prog *prog, 
	if (priv->min_num_stack_tx_queues + num_xdp_tx_queues >

	    priv->num_tx_rings) {

		NL_SET_ERR_MSG_FMT_MOD(extack,

				       "Reserving %d XDP TXQs does not leave a minimum of %d for stack (total %d)",

				       "Reserving %d XDP TXQs leaves under %d for stack (total %d)",

				       num_xdp_tx_queues,

				       priv->min_num_stack_tx_queues,

				       priv->num_tx_rings);