Commit 90574d2a authored by Dan Carpenter's avatar Dan Carpenter Committed by Steven Rostedt (Google)
Browse files

rtla/osnoise: Prevent NULL dereference in error handling 

If the "tool->data" allocation fails then there is no need to call
osnoise_free_top() and, in fact, doing so will lead to a NULL dereference.

Cc: stable@vger.kernel.org
Cc: John Kacur <jkacur@redhat.com>
Cc: "Luis Claudio R. Goncalves" <lgoncalv@redhat.com>
Cc: Clark Williams <williams@redhat.com>
Fixes: 1eceb2fc ("rtla/osnoise: Add osnoise top mode")
Link: https://lore.kernel.org/f964ed1f-64d2-4fde-ad3e-708331f8f358@stanley.mountain


Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
parent d0949cd4

tools/tracing/rtla/src/osnoise_top.c

+4 −7
Original line number Diff line number Diff line
@@ -651,8 +651,10 @@ struct osnoise_tool *osnoise_init_top(struct osnoise_top_params *params) 
		return NULL;



	tool->data = osnoise_alloc_top(nr_cpus);

	if (!tool->data)

		goto out_err;

	if (!tool->data) {

		osnoise_destroy_tool(tool);

		return NULL;

	}



	tool->params = params;
@@ -660,11 +662,6 @@ struct osnoise_tool *osnoise_init_top(struct osnoise_top_params *params) 
				   osnoise_top_handler, NULL);



	return tool;



out_err:

	osnoise_free_top(tool->data);

	osnoise_destroy_tool(tool);

	return NULL;

}



static int stop_tracing;