Commit 905a3468 authored by Matt Roper's avatar Matt Roper Committed by Lucas De Marchi
Browse files

drm/xe/kunit: Fix forcewake assertion in mocs test 



The MOCS kunit test calls KUNIT_ASSERT_TRUE_MSG() with a condition of
'true;' this prevents the assertion from ever failing.  Replace
KUNIT_ASSERT_TRUE_MSG with KUNIT_FAIL_AND_ABORT to get the intended
failure behavior in cases where forcewake was not acquired successfully.

Fixes: 51c0ee84 ("drm/xe/tests/mocs: Hold XE_FORCEWAKE_ALL for LNCF regs")
Cc: Tejas Upadhyay <tejas.upadhyay@intel.com>
Cc: Gustavo Sousa <gustavo.sousa@intel.com>
Reviewed-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: default avatarGustavo Sousa <gustavo.sousa@intel.com>
Link: https://patch.msgid.link/20251113234038.2256106-2-matthew.d.roper@intel.com


Signed-off-by: default avatarMatt Roper <matthew.d.roper@intel.com>
(cherry picked from commit 9be4f0f6)
Signed-off-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
parent d52dea48

drivers/gpu/drm/xe/tests/xe_mocs.c

+1 −1
Original line number Diff line number Diff line
@@ -49,7 +49,7 @@ static void read_l3cc_table(struct xe_gt *gt, 
	fw_ref = xe_force_wake_get(gt_to_fw(gt), XE_FORCEWAKE_ALL);

	if (!xe_force_wake_ref_has_domain(fw_ref, XE_FORCEWAKE_ALL)) {

		xe_force_wake_put(gt_to_fw(gt), fw_ref);

		KUNIT_ASSERT_TRUE_MSG(test, true, "Forcewake Failed.\n");

		KUNIT_FAIL_AND_ABORT(test, "Forcewake Failed.\n");

	}



	for (i = 0; i < info->num_mocs_regs; i++) {