Commit 9069b783 authored Jan 23, 2025 by Sebastian Brzezinka Committed by Andi Shyti Jan 30, 2025

Revert "drm/i915/gt: Log reason for setting TAINT_WARN at reset"



This reverts commit 835443da.

Logging with gt_err() causes CI to detect an error even in cases
of intentional error injection. Since real errors are already
correctly reported by CI, this additional message is unnecessary.

Furthermore, a GT wedge is already being logged elsewhere, so
instead of adjusting the log level, revert the above mentioned
commit to prevent redundant error reporting.

Signed-off-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-by: Krzysztof Niemiec <krzysztof.niemiec@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/pynwwza2xyvicokflxc6lduwwrzwoihihaan54ago3m2xzzagu@qva2ue4tydie

parent 5bea4068

drivers/gpu/drm/i915/gt/intel_reset.c

+1 −5

Original line number	Diff line number	Diff line
		@@ -1113,7 +1113,6 @@ static bool __intel_gt_unset_wedged(struct intel_gt *gt)
		* Warn CI about the unrecoverable wedged condition.
		* Time for a reboot.
		*/
		gt_err(gt, "Unrecoverable wedged condition\n");
		add_taint_for_CI(gt->i915, TAINT_WARN);
		return false;
		}
		@@ -1264,10 +1263,8 @@ void intel_gt_reset(struct intel_gt *gt,
		}

		ret = resume(gt);
		if (ret) {
		gt_err(gt, "Failed to resume (%d)\n", ret);
		if (ret)
		goto taint;
		}

		finish:
		reset_finish(gt, awake);
		@@ -1610,7 +1607,6 @@ void intel_gt_set_wedged_on_init(struct intel_gt *gt)
		set_bit(I915_WEDGED_ON_INIT, &gt->reset.flags);

		/* Wedged on init is non-recoverable */
		gt_err(gt, "Non-recoverable wedged on init\n");
		add_taint_for_CI(gt->i915, TAINT_WARN);
		}