Commit 906dbc47 authored by Guixin Liu's avatar Guixin Liu Committed by Keith Busch
Browse files

nvmet: allow identical cntlid_min and cntlid_max settings 



When the user wants to restrict to only creating one controller,
they can set cntlid_min and cntlid_max to the same value.

Signed-off-by: default avatarGuixin Liu <kanie@linux.alibaba.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
parent 2fcd3ab3

drivers/nvme/target/configfs.c

+2 −2
Original line number Diff line number Diff line
@@ -1274,7 +1274,7 @@ static ssize_t nvmet_subsys_attr_cntlid_min_store(struct config_item *item, 
		return -EINVAL;



	down_write(&nvmet_config_sem);

	if (cntlid_min >= to_subsys(item)->cntlid_max)

	if (cntlid_min > to_subsys(item)->cntlid_max)

		goto out_unlock;

	to_subsys(item)->cntlid_min = cntlid_min;

	up_write(&nvmet_config_sem);
@@ -1304,7 +1304,7 @@ static ssize_t nvmet_subsys_attr_cntlid_max_store(struct config_item *item, 
		return -EINVAL;



	down_write(&nvmet_config_sem);

	if (cntlid_max <= to_subsys(item)->cntlid_min)

	if (cntlid_max < to_subsys(item)->cntlid_min)

		goto out_unlock;

	to_subsys(item)->cntlid_max = cntlid_max;

	up_write(&nvmet_config_sem);