Commit 9078f01f authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Ulf Hansson
Browse files

mmc: renesas_sdhi: add regulator dependency 



The driver started using the regulator subsystem and fails to build without
a dependeny on CONFIG_REGULATOR:

ERROR: modpost: "rdev_get_drvdata" [drivers/mmc/host/renesas_sdhi_core.ko] undefined!
ERROR: modpost: "devm_regulator_register" [drivers/mmc/host/renesas_sdhi_core.ko] undefined!

The 'select RESET_CONTROLLER' needs to either go away or get changed to a dependency
in order to avoid Kconfig dependency loops here. It also turns out the the superh
version needs neither RESET_CONTROLLER nor REGULATOR, and this works because
CONFIG_OF is not set there.

Change both to a 'depends on', but add '|| !OF' for the superh case.

Fixes: fae80a99 ("mmc: renesas_sdhi: Add support for RZ/G3E SoC")
Tested-by: default avatarBiju Das <biju.das.jz@bp.renesas.com>
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20250329164145.3194284-1-arnd@kernel.org


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 649b50a8

drivers/mmc/host/Kconfig

+1 −1
Original line number Diff line number Diff line
@@ -691,8 +691,8 @@ config MMC_TMIO_CORE 
config MMC_SDHI

	tristate "Renesas SDHI SD/SDIO controller support"

	depends on SUPERH || ARCH_RENESAS || COMPILE_TEST

	depends on (RESET_CONTROLLER && REGULATOR) || !OF

	select MMC_TMIO_CORE

	select RESET_CONTROLLER if ARCH_RENESAS

	help

	  This provides support for the SDHI SD/SDIO controller found in

	  Renesas SuperH, ARM and ARM64 based SoCs