Commit 9080b5d1 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

gpio: mvebu: use value returning setters 



struct gpio_chip now has additional variants of the set(_multiple)
driver callbacks that return an integer to indicate success or failure.
Convert the driver to using them.

Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Acked-by: default avatarUwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://lore.kernel.org/r/20250220-gpio-set-retval-v2-15-bc4cfd38dae3@linaro.org


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent f01436c2

drivers/gpio/gpio-mvebu.c

+4 −4
Original line number Diff line number Diff line
@@ -298,11 +298,11 @@ static unsigned int mvebu_pwmreg_blink_off_duration(struct mvebu_pwm *mvpwm) 
/*

 * Functions implementing the gpio_chip methods

 */

static void mvebu_gpio_set(struct gpio_chip *chip, unsigned int pin, int value)

static int mvebu_gpio_set(struct gpio_chip *chip, unsigned int pin, int value)

{

	struct mvebu_gpio_chip *mvchip = gpiochip_get_data(chip);



	regmap_update_bits(mvchip->regs, GPIO_OUT_OFF + mvchip->offset,

	return regmap_update_bits(mvchip->regs, GPIO_OUT_OFF + mvchip->offset,

				  BIT(pin), value ? BIT(pin) : 0);

}
@@ -1173,7 +1173,7 @@ static int mvebu_gpio_probe(struct platform_device *pdev) 
	mvchip->chip.direction_input = mvebu_gpio_direction_input;

	mvchip->chip.get = mvebu_gpio_get;

	mvchip->chip.direction_output = mvebu_gpio_direction_output;

	mvchip->chip.set = mvebu_gpio_set;

	mvchip->chip.set_rv = mvebu_gpio_set;

	if (have_irqs)

		mvchip->chip.to_irq = mvebu_gpio_to_irq;

	mvchip->chip.base = id * MVEBU_MAX_GPIO_PER_BANK;