Commit 9082f24b authored by JaeJoon Jung's avatar JaeJoon Jung Committed by Andrew Morton
Browse files

mm/damon/stat: deduplicate intervals_goal setup in damon_stat_build_ctx() 

The damon_stat_build_ctx() function sets the values of intervals_goal
structure members.  These values are applied to damon_ctx in
damon_set_attrs().  However, It is resetting the values that were already
applied previously to the same values.  I suggest removing this code as it
constitutes duplicate execution.

Link: https://patch.msgid.link/20251206011716.7185-1-rgbi3307@gmail.com
Link: https://lkml.kernel.org/r/20251216073440.40891-1-sj@kernel.org


Signed-off-by: default avatarJaeJoon Jung <rgbi3307@gmail.com>
Reviewed-by: default avatarEnze Li <lienze@kylinos.cn>
Reviewed-by: default avatarSeongJae Park <sj@kernel.org>
Signed-off-by: default avatarSeongJae Park <sj@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 804c26b9

mm/damon/stat.c

+0 −8
Original line number Diff line number Diff line
@@ -173,14 +173,6 @@ static struct damon_ctx *damon_stat_build_ctx(void) 
	if (damon_set_attrs(ctx, &attrs))

		goto free_out;



	/*

	 * auto-tune sampling and aggregation interval aiming 4% DAMON-observed

	 * accesses ratio, keeping sampling interval in [5ms, 10s] range.

	 */

	ctx->attrs.intervals_goal = (struct damon_intervals_goal) {

		.access_bp = 400, .aggrs = 3,

		.min_sample_us = 5000, .max_sample_us = 10000000,

	};

	if (damon_select_ops(ctx, DAMON_OPS_PADDR))

		goto free_out;